Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Refactor pkg/providers #252

Merged
merged 5 commits into from
Jul 31, 2019
Merged

Refactor pkg/providers #252

merged 5 commits into from
Jul 31, 2019

Conversation

luxas
Copy link
Contributor

@luxas luxas commented Jul 31, 2019

To allow for splitting out ignited, and to reduce the amount of deps for ignite-spawn.

Dependencies (checked with go list -f '{{ join .Deps "\n" }}' ./cmd/ignite-spawn | grep "\." | wc -l):

  • Before:
    • ignite-spawn: 199
    • ignite: 162
  • After:
    • ignite-spawn: 164 (-17.5%)
    • ignite: 168

Binary size:

  • Before:
    • ignite-spawn: 27436625 bytes
    • ignite: 23022323 bytes
  • After:
    • ignite-spawn: 25985295 bytes (-5.2%)
    • ignite: 23032748 bytes

@luxas luxas added this to the v0.5.0 milestone Jul 31, 2019
@luxas luxas added the kind/refactor Categorizes issue or PR as related to refactoring code. label Jul 31, 2019
twelho
twelho approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@twelho twelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!
LGTM 👍

@twelho twelho merged commit b1d3997 into weaveworks:master Jul 31, 2019
@luxas luxas mentioned this pull request Jul 31, 2019
Closed
@luxas luxas added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@twelho twelho twelho approved these changes

Assignees

@twelho twelho

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/refactor Categorizes issue or PR as related to refactoring code.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@luxas @twelho